Repository navigation
fix: Azure AI Search - return all documents from filter_documents whe… - #4277
Open
davidsbatista wants to merge 2 commits into
Open
davidsbatista wants to merge 2 commits into
davidsbatista wants to merge 2 commits into
Conversation
Contributor
Coverage report (azure_ai_search)Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
davidsbatista
marked this pull request as ready for review
November 16, 2026 15:20
davidsbatista
requested review from
bogdankostic
and removed request for
a team
November 16, 2026 15:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
When called with no filters,
AzureAISearchDocumentStore.filter_documents()fell back tosearch_documents(), which defaults totop_k=10. So it returned at most 10 documents no matter how many were in the index.filter_documents()now makes a singleclient.search(search_text="*", filter=...)call for both cases (with or without filters) and passes notop. The SDK pager then keeps following the service's continuation tokens until every match is returned.Azure AI Search pages with
$skip, which is capped at 100,000. When the result count reaches that limit, a warning is logged saying the result may be incomplete and suggesting a narrower filter. The docstring says the same.search_documents()is unchanged.How did you test it?
topis senttopis sent and the filter is passed through