Repository navigation
Conversation
ABACUS-PR-BOT
left a comment
Collaborator
There was a problem hiding this comment.
The inlined adapter preserves the prior packing, unit conversions and call order by static inspection. No build or runtime test was run in this review; PLUMED-enabled behavior remains unverified.
| collect_plumed_cell(mdcell, plumed_cell); | ||
| std::vector<LocalAtom>& atoms = mdcell.owned_atoms(); | ||
| const double lat0 = mdcell.lat0(); | ||
| plumed_positions.resize(atoms.size()); |
Collaborator
There was a problem hiding this comment.
Non-blocking: The cited MODULE_MD_run tests cover cell preparation and output cadence without calling md_line, so they do not exercise these buffer conversions or force write-back. A focused adapter test with distinct atoms, a non-unit lat0, an off-diagonal cell and a known bias-force update would protect this boundary; an enabled PLUMED case or a controlled test double could exercise it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.source/changes.Linked Issue
No issue is needed for this small, behavior-preserving cleanup of code introduced by #8057.
Unit Tests and/or Case Tests for my changes
cmake --build build_parallel_md1_current --target md -j4— passed.cmake --build build_parallel_md1_current --target MODULE_MD_run -j4— passed.ctest --test-dir build_parallel_md1_current -R '^MODULE_MD_run$' --output-on-failure— passed, 1/1 test.git diff --cached --check— passed.python3 tools/03_code_analysis/agent_governance_check.py --staged— passed with test-evidence and documentation-review warnings.ENABLE_PLUMED=OFF).What's changed?
run_plumed_stepinsource/source_md/run_md.cpp.plumed.move.Governance Notes
source/source_md/run_md.cpp; no changes to ESolver, HSolver, ElecState, Hamilt, Operator, or Psi.