Repository navigation
Conversation
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
Two issues remain: the NEP header rename breaks the enabled-backend include path, and the moved missing-restart test shares a directory with restart writers. Static review only; no build or runtime tests were executed, and author-reported results were not independently verified.
Non-blocking: Please consolidate the repeated verification/change sections and restore the two truncated Cell CTest commands. Their regex quotes and code spans currently run into later sections, so the selections cannot be copied or checked against the reported pass counts.
| * @date 2025-10-10 | ||
| */ | ||
| #include "nep_potential.h" | ||
| #include "nep.h" |
There was a problem hiding this comment.
With NEP enabled, the conditional #include "nep.h" below now resolves to this newly renamed wrapper again. Its include guard suppresses the second include, leaving ::NEP incomplete, so the allocation, member calls, and unique_ptr destruction cannot compile. Please make the wrapper/backend includes unambiguous and verify a build with NEP_DIR configured.
| initialize_mdcell_from_ucell(mdcell, ucell, decomp); | ||
| int istep = 0; | ||
| double temperature = 0.0; | ||
| EXPECT_EXIT(MD_func::current_md_info(mdcell, "./", istep, temperature), ::testing::ExitedWithCode(1), ""); |
There was a problem hiding this comment.
This missing-file assertion now shares its working directory with restart writers such as FIREtest.WriteRestart. A parallel run or a leftover ./Restart_md.txt can make current_md_info return normally and fail the death test. Please pass a unique empty directory under testing::TempDir().
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.source/changes.Linked Issue
Fixes #8298
Unit Tests and/or Case Tests for my changes
ctest --test-dir /tmp/abacus-md-serial --output-on-failure -R '^MODULE_MD|^MODULE_ESOLVER_forcefields$|^MODULE_CELL_NEIGHBOR_domain_decomposition_serial$'— 18/18 passed.env OMP_NUM_THREADS=1 LD_LIBRARY_PATH=/usr/lib/x86_64-linux-gnu/openblas-pthread:$LD_LIBRARY_PATH ctest --test-dir build_parallel_md1_current --output-on-failure -R '^MODULE_MD|^MODULE_ESOLVER_forcefields$|^MODULE_CELL_NEIGHBOR_(domain_decomposition|mdcell_migrate_mpi)'— 28/28 passed (run outside the restricted sandbox).git diff --check origin/develop...HEAD— passed.ABACUS version v3.11.0-beta13.What's changed?
source/source_md/unittests/with one owning test file per source, including mergedmd_baseandmd_funcsuites and a dedicatedMODULE_MD_basetarget.ENABLE_MPI; retain MPI-specific test targets.module_neighlisttests fromtest/intounittests/, including domain decomposition; preserve the existing serial, MPI, and CUDA target conditions.nep/snap, updating build lists and includes; class names and runtime behavior are unchanged.md_statistics.hand obsolete test directories/files.Governance Notes
` — 1/1 passed after the Cell directory consolidation.
git diff --check origin/develop...HEAD— passed.ABACUS version v3.11.0-beta13.What's changed?
source/source_md/unittests/with one owning test file per source, including mergedmd_baseandmd_funcsuites and a dedicatedMODULE_MD_basetarget.ENABLE_MPI; retain MPI-specific test targets.module_neighlisttests fromtest/intounittests/, including domain decomposition; preserve the existing serial, MPI, and CUDA target conditions.nep/snap, updating build lists and includes; class names and runtime behavior are unchanged.md_statistics.hand obsolete test directories/files.Governance Notes
` — 8/8 passed after the Cell directory consolidation (outside the restricted sandbox).
python3 tools/03_code_analysis/agent_governance_check.py --base origin/develop --head HEAD --format text— exit 0; documentation-sync review warning addressed below.git diff --check origin/develop...HEAD— passed.ABACUS version v3.11.0-beta13.What's changed?
source/source_md/unittests/with one owning test file per source, including mergedmd_baseandmd_funcsuites and a dedicatedMODULE_MD_basetarget.ENABLE_MPI; retain MPI-specific test targets.module_neighlisttests fromtest/intounittests/, including domain decomposition; preserve the existing serial, MPI, and CUDA target conditions.nep/snap, updating build lists and includes; class names and runtime behavior are unchanged.md_statistics.hand obsolete test directories/files.Governance Notes