Repository navigation
fix(ase): backport bundled calculator and parser corrections #8319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
QuantumMisaka
wants to merge
11
commits into
deepmodeling:develop
Choose a base branch
from
QuantumMisaka:fix/ase-upstream-abacuslite
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
acf6590
fix(ase): backport bundled calculator and parser corrections
QuantumMisaka 770926e
fix(ase): keep result handoff compatible with ASE
QuantumMisaka d3eb7bf
refactor(ase): share result schema projection
QuantumMisaka f24cbb1
style(ase): make schema projection cardinality explicit
QuantumMisaka 2bb94cc
fix(ase): use English diagnostics for SCF matching
QuantumMisaka 8f8c398
refactor(ase): keep only required SCF reference data
QuantumMisaka 2496fb7
style(ase): simplify atom-order validation
QuantumMisaka 0d7a9c3
refactor(ase): defer result shapes to ASE schema
QuantumMisaka da89f32
refactor(ase): trim backport scope and address reader review
QuantumMisaka 329bdf8
refactor(ase): remove redundant frame and result bookkeeping
QuantumMisaka 2ffe3c7
fix(ase): normalize output geometry at the reader boundary
QuantumMisaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking: the recommended
examples/soc.pyandtests/magnetic.pystill replace ASE’s global magnetic-property definitions. The new handoff no longer needs that workaround; removing it would align these consumers with the documented behavior and avoid rejecting later collinear results in the same process.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 770926e: removed the global ASE magnetic-property mutation from
examples/soc.pyandtests/magnetic.py. The calculator now handles vector moments locally.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The global magnetic-property mutations remain removed from both examples/soc.py and tests/magnetic.py. This consumer correction is retained in the reduced diff; it is not part of the test-directory removal (329bdf8).