Repository navigation
refactor(lcao): make block-cyclic layout access explicit via para_2d() - #8269
Merged
mohanchen merged 9 commits intoNov 3, 2026
Merged
Conversation
Purely additive: no call site changes, inheritance still in place. para_2d() (const + non-const) returns *this while Parallel_Orbitals derives from Parallel_2D, giving the two escape hatches a const getter cannot serve (LR_Util::setup_2d_division mutation, test-side descriptor writes). get_blacs_ctxt() completes the inherited getter family, which covers the other seven public data members.
…rate module_rt call sites
…igrate module_dftu call sites
…rate module_dm call sites
…rate module_lr call sites
…bitals, migrate module_operator_lcao call sites
…, migrate module_current call sites
ABACUS-PR-BOT
left a comment
Collaborator
There was a problem hiding this comment.
Non-blocking: Please add the exact unit-test build and CTest commands, plus the serial/MPI build configuration, behind the reported 20/20 result to the Verification section so others can reproduce it.
Static review of a1c9b4967f75; no builds or tests were run.
AsTonyshment
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the LCAO-side consumers of
Parallel_Orbitalsrequest their block-cyclic layout explicitly throughpara_2d(), following the merged PR #8254.This PR covers
module_dm,module_dftu,module_lr,module_operator_lcao, andmodule_current.Parallel_2Dinheritance is intentionally retained in this PR.Motivation
Inherited layout members hide whether a
pvdependency represents basis, wavefunction, or matrix layout. This change makes those dependencies explicit and isolates the remaining consumers before a subsequent PR removes the inheritance.Changes
Parallel_2Dmembers to explicitpara_2d()access.upstream/develop, including the merged PR refactor(rt): make block-cyclic layout access explicit via para_2d() #8254.Non-goals
Parallel_2Dinheritance.BlockCyclicDistributionInformationorMatrix2das the public layout boundary.Verification
cmake --build build --target abacus_basic_para -j2: passed.MODULE_ESTATE_dm_*,MODULE_DFTU_*,MODULE_LCAO_operator_*, andMODULE_LR_*.git diff --check upstream/develop...HEAD: passed.operator_lr_hxc.cppis migration-neutral.Stack