Repository navigation
Conversation
Collaborator
|
reopen when it is not a draft |
…jector-mesh-regression
ABACUS-PR-BOT
left a comment
Collaborator
There was a problem hiding this comment.
Static review at e1bcf0a found no production defect in the per-type grid setup or borrowed radial inputs. The regression needs CI selection as noted below. No builds, runtime tests or CI diagnostics were performed; the reported CTest pass was not independently rerun.
mohanchen
reviewed
Nov 3, 2026
mohanchen
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.source/changes.Linked Issue
No issue: the mixed-mesh bounds fix and
orbital_dirargument use are already ondevelop. This PR keeps only the small onsite projector setup optimization. Existing FeO mixed-atom-order cases remain undertests/17_DS_DFTU.Unit Tests and/or Case Tests for my changes
cmake --build /tmp/abacus-onsite-build --target abacus_pw_ser -j 8;ctest --test-dir /tmp/abacus-onsite-build -N -R '^17_DS_DFTU_onsite_mesh$';git diff upstream/develop...HEAD --check;python3 tools/03_code_analysis/agent_governance_check.py --staged;python3 tools/03_code_analysis/code_quality_score.py --format json source/source_pw/module_proj/onsite_proj_init.cpp. The focused onsite test also passed locally (1/1) before it was removed from this PR.develop.17_DS_DFTUintegration suite and GPU build. The PR changes no projector mathematics or GPU-specific code.What's changed?
smoothgen, avoiding repeated grid work and copies for multiple projectors.parameter.hinclude; this translation unit does not readPARAM.Governance Notes