Skip to content

Reduce repeated onsite projector setup and cover mixed orbital meshes - #8239

Merged
mohanchen merged 7 commits into
deepmodeling:developfrom
lanshuyue:codex/onsite-projector-mesh-regression
Nov 4, 2026
Merged

mohanchen merged 7 commits into
deepmodeling:developfrom
lanshuyue:codex/onsite-projector-mesh-regression

Conversation

@lanshuyue

@lanshuyue lanshuyue commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Reminder

  • I have read AGENTS.md and docs/developers_guide/agent_governance.md.
  • I have linked an issue or explained why this PR does not need one.
  • I have added adequate unit tests and/or case tests, or explained why not.
  • I have listed the exact verification commands run and their results.
  • I have described user-visible behavior changes, including INPUT parameter changes.
  • I have explained core-module impact for ESolver, HSolver, ElecState, Hamilt, Operator, Psi, or other source/ changes.
  • I have requested any needed governance exception below.

Linked Issue

No issue: the mixed-mesh bounds fix and orbital_dir argument use are already on develop. This PR keeps only the small onsite projector setup optimization. Existing FeO mixed-atom-order cases remain under tests/17_DS_DFTU.

Unit Tests and/or Case Tests for my changes

  • Commands run: cmake --build /tmp/abacus-onsite-build --target abacus_pw_ser -j 8; ctest --test-dir /tmp/abacus-onsite-build -N -R '^17_DS_DFTU_onsite_mesh$'; git diff upstream/develop...HEAD --check; python3 tools/03_code_analysis/agent_governance_check.py --staged; python3 tools/03_code_analysis/code_quality_score.py --format json source/source_pw/module_proj/onsite_proj_init.cpp. The focused onsite test also passed locally (1/1) before it was removed from this PR.
  • Result summary: build passed; CTest lists 0 tests with the removed name. Diff and staged governance checks passed. Quality score is 91/100, unchanged from current develop.
  • Checks not run: the full 17_DS_DFTU integration suite and GPU build. The PR changes no projector mathematics or GPU-specific code.

What's changed?

  • Generate each atom type's radial grid once and pass the parsed radial vector directly to smoothgen, avoiding repeated grid work and copies for multiple projectors.
  • Remove an unused parameter.h include; this translation unit does not read PARAM.

Governance Notes

  • INPUT/docs changes: no INPUT syntax, diagnostic text, or valid-input numerical behavior changes. No documentation update is needed for the internal setup optimization and include cleanup.
  • Core module impact: limited to PW onsite projector initialization; no interface or solver changes.
  • Test rationale: no new test remains in this PR. The added smoke test was removed after review to keep this performance cleanup focused; existing FeO cases remain available for manual checks.
  • Exceptions requested: none.

@mohanchen

Copy link
Copy Markdown
Collaborator

reopen when it is not a draft

@mohanchen mohanchen closed this Nov 1, 2026
@lanshuyue lanshuyue reopened this Nov 1, 2026
@lanshuyue
lanshuyue marked this pull request as ready for review November 1, 2026 17:25

@ABACUS-PR-BOT ABACUS-PR-BOT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review at e1bcf0a found no production defect in the per-type grid setup or borrowed radial inputs. The regression needs CI selection as noted below. No builds, runtime tests or CI diagnostics were performed; the reported CTest pass was not independently rerun.

Comment thread tests/17_DS_DFTU/CMakeLists.txt Resolved
Comment thread .github/workflows/test.yml Resolved
@mohanchen mohanchen added DFT+U Issues related to DFT plus U function Refactor Refactor ABACUS codes labels Nov 4, 2026
@mohanchen
mohanchen merged commit 2bd1c0d into deepmodeling:develop Nov 4, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DFT+U Issues related to DFT plus U function Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants