Repository navigation
Conversation
Each entry of the top queries and top errors lists already has a unique id on its details cell. Add a small link pointing to that id so a specific entry can be linked. 14 places are changed: - time consuming queries, most frequent queries, slowest normalized queries - time consuming prepare and time consuming bind queries - most frequent waiting queries and queries that waited the most - queries generating the most temporary files and the largest temporary files - most cancellation queries and most cancelled queries - most frequent errors - pgbouncer most frequent errors - pgbouncer most used reserved pool The link is placed before the query block, floated to the right. Fixes darold#857 Signed-off-by: João Rito <16895040+ritojoao@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Gilles,
Thank you for pgBadger and for being open to the idea in #857. Here is a small change for it.
Each entry in the top queries and top errors lists already has a unique
idon its details cell, for exampletime-consuming-queries-examples-details-rank-1. This PR adds a small pilcrow link (¶) at the top right of that cell, before the query. The link points to that id, so a specific entry can be shared with a URL likeindex.html#time-consuming-queries-examples-details-rank-3.It adds 14 links (14 added lines, only in
pgbadger):The links use an inline style (
float:right;text-decoration:none;). The embedded CSS is generated bytools/updt_embedded_rsc.pl, which needsyui-compressor, and I do not have it. If you prefer a CSS class, I can change it.I did not change the docs, since this is a visual detail of the report and nothing in
doc/pgBadger.poddescribes it. Please tell me if you would like a line in the docs or in the ChangeLog.I have not looked at the result in a browser.
How I checked it:
t/fixturesbefore and after the change. Apart from the new links, the HTML is identical, and the number of SQL entries and of ids is the same.pgbouncer.log.gzto see those two links.prove -l t/gives the same result before and after.t/02_basics.t(test 17) andt/08_remote_watch.t(test 6) fail on my machine with or without the change.One thing I noticed and left alone: a few older ids such as
query-e-1are reused in different sections, so they are not unique in some reports. My links do not use them. I can send a separate fix if you want.Fixes #857