Repository navigation
feat(sales): render Needs attention task rows (#7392) - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gather #7392 — render Needs attention task rows using the existing protected query from merged PR #58.
Scope boundaries
No new permissions, backend/schema changes, task-completion or rescheduling actions. Those actions belong to Gather #7371. Recent work and ongoing activities remain placeholders. Unrelated local planning files are excluded.
Verification
Fresh publication checks:
pnpm --dir apps/web exec vitest run— 25 files, 417 tests passed.pnpm exec tsc --noEmit -p apps/web/tsconfig.json— passed.pnpm run fmt— passed.pnpm exec oxlintfor the changed component/API/tests — zero warnings/errors.git diff --checkand staged equivalent — passed.Browser verification during implementation passed for the real persisted task row, priority badge, read-only Review (before/after persisted task comparison), desktop/mobile geometry, light/dark themes, section error isolation/retry and zero JavaScript errors.
On publication recheck, the original row assertion failed because local task 434 is now DONE, not because of a UI change. A fresh signed-in check confirmed HTTP 200 with an empty queue, the correct empty state, completed task exclusion, unchanged persisted task data and zero JavaScript errors. No task data was changed to make the check pass.
Review limitation
The independent reviewer tool failed before running (
DaemonThreadPoolExecutorinitialization error). No independent-review approval is claimed. Local checks above are distinct from GitHub CI; CI status must be read separately.