Skip to content

feat(sales): render Needs attention task rows (#7392) - #59

Merged
poisvin merged 1 commit into
mainfrom
feat/sales-attention-rows-7392
Nov 6, 2026
Merged

poisvin merged 1 commit into
mainfrom
feat/sales-attention-rows-7392

Conversation

@poisvin

@poisvin poisvin commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Gather #7392 — render Needs attention task rows using the existing protected query from merged PR #58.

  • Show title, stable assignee, due/overdue date, person link and High/Urgent badge.
  • Add server pagination, loading/empty/error states and retry without blocking other sections.
  • Scope request headers and query keys to the organization and local date; reset page and Review on organization/date changes and refresh cutoff after midnight.
  • Add a read-only Review Sheet and link to the existing full task page. Opening/closing does not mutate the task.
  • Preserve approved desktop panel geometry, mobile stacking and light/dark styles.

Scope boundaries

No new permissions, backend/schema changes, task-completion or rescheduling actions. Those actions belong to Gather #7371. Recent work and ongoing activities remain placeholders. Unrelated local planning files are excluded.

Verification

Fresh publication checks:

  • pnpm --dir apps/web exec vitest run — 25 files, 417 tests passed.
  • pnpm exec tsc --noEmit -p apps/web/tsconfig.json — passed.
  • pnpm run fmt — passed.
  • Targeted pnpm exec oxlint for the changed component/API/tests — zero warnings/errors.
  • git diff --check and staged equivalent — passed.
  • Added-line static security scan: no findings; diff manually reviewed.

Browser verification during implementation passed for the real persisted task row, priority badge, read-only Review (before/after persisted task comparison), desktop/mobile geometry, light/dark themes, section error isolation/retry and zero JavaScript errors.

On publication recheck, the original row assertion failed because local task 434 is now DONE, not because of a UI change. A fresh signed-in check confirmed HTTP 200 with an empty queue, the correct empty state, completed task exclusion, unchanged persisted task data and zero JavaScript errors. No task data was changed to make the check pass.

Review limitation

The independent reviewer tool failed before running (DaemonThreadPoolExecutor initialization error). No independent-review approval is claimed. Local checks above are distinct from GitHub CI; CI status must be read separately.

@poisvin
poisvin merged commit 6747423 into main Nov 6, 2026
1 check passed
@poisvin
poisvin deleted the feat/sales-attention-rows-7392 branch November 6, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant