[neznaika0]

Description

1. Tests are run for individual methods, instead of check(). Otherwise, it’s unclear at which stage the error occurs.
   There is a proposal to move mb_strtolower($password) inside for clarity.
2. By allowing Unicode, the $trivial check now loses its relevance for other languages.

• Unicode support has been added. User data may contain multibyte characters: in the email, username, lastname and other User properties.
• The phpDoc has been slightly corrected
• Tests for the case when User = null is passed
• strip_explode() also understands Unicode
• Checking a reversed Unicode username is impossible

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[paulbalandan]

The MBString mutation suggests the tests did not cover multibyte passwords, which this change is anchoring on.

[neznaika0]

I haven’t used Infection. Does this mean that my version of the tests works in both strtolower() variants?
Perhaps it will work if the exact strings are the same. But we understand that there is a difference:

$ php -r "var_dump(strtolower('ПёТр'), mb_strtolower('ПёТр')); ";
string(8) "ПёТр"
string(8) "пётр"

[paulbalandan]

yes, your test passes in both variants. infection must see your test fails when it changes things to say you covered the mutant