Repository navigation
docs: show Codacy Self-hosted facts per version on the chart pages [OD-1044] - #2800
claudiacodacy wants to merge 4 commits into
Conversation
…D-1044] - Add "What's available on Codacy Self-hosted" from the approved feature list. - Bring the six Self-hosted-only pages from release/v14.0 into chart/using-codacy/. - Render Kubernetes, MicroK8s, and PostgreSQL requirements from the version data. - Kubernetes for v15.0.0 and v16.0.0 follows the release notes, checked against chart CI. - Configuration helm commands get one tab per version; install and upgrade use the latest. - Fix the upgrade page's tool links: the self-hosted-X tags stop at 11.0.0. - self_hosted_tabs() takes an indent, so it can sit inside a list item. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Overall readability score: 54.44 (🔴 -0.02)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
Two blocking documentation correctness issues remain: the published MicroK8s requirement contradicts the evidence in the same data file, and the Security Monitor page contains malformed table markup. These should be corrected before merging.
The strict documentation build and version-aware rendering scenarios have not been automated or otherwise demonstrated in the supplied review data, leaving the acceptance criteria around generated output and selected-version commands unverified.
Test suggestions
- Build the documentation strictly and verify all version macros, tables, and tabs render without unresolved template text.
- Test self_hosted_tabs indentation inside numbered lists and verify tab groups remain correctly structured.
- Verify self_hosted_table renders every supported version and requested field in the expected order.
- Verify installation, upgrade, and configuration commands use the intended latest or selected Self-hosted version.
- Validate the HTML structure of the newly added Security Monitor page.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Build the documentation strictly and verify all version macros, tables, and tabs render without unresolved template text.
2. Test self_hosted_tabs indentation inside numbered lists and verify tab groups remain correctly structured.
3. Verify self_hosted_table renders every supported version and requested field in the expected order.
4. Verify installation, upgrade, and configuration commands use the intended latest or selected Self-hosted version.
5. Validate the HTML structure of the newly added Security Monitor page.
Low confidence findings
- Add automated documentation-build and rendering checks for the new version-aware macros and templates.
TIP How was this review? Give us feedback
- Release note for v17.0.0 (stable chart published 2026-09-02), registered in the index and nav. No component changes from v16.0.0; one upgrade-hook fix. - Data row for v17.0.0, so install, upgrade, and the version tabs use it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… MicroK8s for v16+ [OD-1044]
- Helm templates sit in a fenced block inside {% set command %}, so Vale reads them as
code; add "endset" to the Codacy vocabulary. Document the pattern in formatting.md.
- v17.0.0 note: drop the unused codacy_tools_version_* keys, format @coffeelint/cli as code.
- Security Monitor (copied from v14): add the missing <tr> before PHP, drop a stray </a>
in the C++ row, close the footnote <span>.
- MicroK8s for v16.0.0 and v17.0.0 is 1.30 to 1.33, the range the chart CI installs on.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…044] The page references three status images and the Code patterns page from raw HTML, which the copy from release/v14.0 didn't carry over or re-base. htmltest flagged all four. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With one unversioned site, the Self-hosted section has to say what each supported version has and needs. This PR uses the version data from #2799 across the chart pages, adds a page listing what's on Self-hosted, and brings in the six Self-hosted-only pages that existed only in the frozen
/v14.0/build. Part of P-OD-602 / OD-1044.New pages
chart/whats-available-on-codacy-self-hosted.md, from the approved feature list in OD-1044: what's available (linked to the Cloud pages that apply), what's different, and what's only on Codacy Cloud. Codacy CLI v2 is Cloud-only: it hard-codeshttps://app.codacy.com(codacy-cli-v2@5cc84de,codacy-client/client.go:17).chart/using-codacy/, copied fromrelease/v14.0@49a7c7f with their images: Adjusting quality settings, Configuring file extensions, Security Monitor, and the repository-level Jira, Slack, and webhook notifications. Links are fixed for the new folder. The "paid plans" notice is removed from Security Monitor, since Self-hosted is licensed.Per-version facts
chart/index.md: a supported-versions statement and the fullself_hosted_table().chart/requirements.md: Kubernetes, MicroK8s, and PostgreSQL versions come from the data file instead of hard-coded text.1.22 to 1.27, and 1.30(CI installs on 1.19–1.27 and 1.30).1.30 to 1.33(CI installs on 1.30–1.33 only;codacy/chart0a1a1cd removed the older jobs).Helm commands
--version 15.0.0, so a v14 customer reconfiguring would upgrade by accident. The tabs are linked, so picking a version once selects it across the site.self_hosted_latest.version(17.0.0) instead of the staleextra.codacy_self_hosted_version(15.0.0). The values-file links resolve at tag 16.0.0.self-hosted-Xtags on the tool repos stop at 11.0.0. They now point to the versions in the data file (Analysis CLI 7.9.5, Coverage Reporter 13.10.15), and both releases exist.{% set command %}, so Vale reads it as code, andendsetis in the Codacy vocabulary.self_hosted_tabs()takesindent, so it can sit inside a numbered step. Documented in.claude/reference/formatting.md.v17.0.0 as the latest version
self-hosted-v17.0.0.md, registered inrelease-notes/index.mdand the nav. Thecodacychart 17.0.0 has been on the stable channel since 2026-09-02, but no note was written.requirements.lockmatches 16.0.0 apart from its timestamp, andcodacy-tools-shstays at 1.2.21, so the tool list is the same.BackoffLimitExceededin the log-retention hook job (codacy/chartfix: Update latest chart version #839–fix: Add note for bulk copy of patterns in Self-hosted 4.2.0 #843).TODO: verify:codacy/values.yamlchanges the default RabbitMQ tag from3.8.35-debian-11-r5to3.8.5. Does that need an upgrade note?Still to verify
1.19/stablechannel; chart owners, please confirm whether it should move to 1.33.extra.codacy_self_hosted_versionis no longer used underdocs/chart/; removing it everywhere is OD-1038.Verification
mkdocs build --strictpasses.👀 Live preview
🚧 To do
🤖 Generated with Claude Code