Repository navigation
Shut down chdb-core before Node process exit - #98
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Tested with the official chdb-core v26.9.0 macOS arm64 release library. The codegen subprocess hung before the fix and exits successfully after it.
The excluded network-blackhole integration test timed out in this local environment; the remaining platforms and full suite need PR CI. This does not change the currently pinned engine v26.7.3.
Fixes #97
Note
Shut down chdb-core before Node process exit
shutdown_on_process_exitin chdb_node.cpp, a process-wide exit handler that closes all registered connections and then runs engine shutdown.get_default_connandacquire_session_connto after a connection opens successfully, so failed connection creation no longer registers cleanup.Macroscope summarized fa0afaf.