Repository navigation
Move the engine pin to v26.7.3 - #94
Merged
Merged
Conversation
|
|
|
|
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ShawnChen-Sirius
added a commit
that referenced
this pull request
Sep 11, 2026
The release check rewrites the two version lines in update_libchdb.sh and package.json, which is all the version-scheme check reads, so PR #94 is correct as far as anything enforced goes. It leaves behind the places that name the pin in prose, and those now contradict it. Three are live claims rather than history: - README's durable section states the engine a caller needs. - chdb-node-test.yml's header states what the suite runs against. - durable-control-plane.md's "still to do" states the version the release workflow will derive the subpackage from. Left alone deliberately: the sentences recording that v26.7.2-rc.2 was the first release to carry the durable ABI and that the S3 conformance run used it, which stay true; "the newest published is 26.7.0-stable.1", still accurate on npm; and the version literals in test/durable and src/durable/version.ts, which are comparison fixtures, not the pin. The main package version stays at 3.2.0. prebuild-publish.yml sets it from the tag ref, which is why v3.3.0 shipped from a tree that also said 3.2.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The release check rewrites the two version lines in update_libchdb.sh and package.json, which is all the version-scheme check reads, so PR #94 is correct as far as anything enforced goes. It leaves behind the places that name the pin in prose, and those now contradict it. Three are live claims rather than history: - README's durable section states the engine a caller needs. - chdb-node-test.yml's header states what the suite runs against. - durable-control-plane.md's "still to do" states the version the release workflow will derive the subpackage from. Left alone deliberately: the sentences recording that v26.7.2-rc.2 was the first release to carry the durable ABI and that the S3 conformance run used it, which stay true; "the newest published is 26.7.0-stable.1", still accurate on npm; and the version literals in test/durable and src/durable/version.ts, which are comparison fixtures, not the pin. The main package version stays at 3.2.0. prebuild-publish.yml sets it from the tag ref, which is why v3.3.0 shipped from a tree that also said 3.2.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ShawnChen-Sirius
force-pushed
the
engine-pin-v26.7.3
branch
from
September 11, 2026 05:30
276b6c1 to
d09c280
Compare
Contributor
|
@wudidapaopao please review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release check ran the v2 and v3 suites against
v26.7.3onall four platforms and they passed, so the engine can be adopted. This
moves the pin v26.7.2-rc.2 →
v26.7.3.LIBCHDB_NPM_VERSIONand the@chdb/lib-<platform>pins move with it,to
26.7.3-stable.1— the version has to name the engine inside it, and thecounter restarts because this engine has not been packaged before. Merging
this does not publish anything; that is still a separate decision.
https://github.com/chdb-io/chdb-node/actions/runs/34561725463
Based on 0559be3, the commit that run tested.
No checks will appear here. GitHub does not start workflow runs for
commits a workflow pushed with
GITHUB_TOKEN, and running CI on thisbranch would exercise the same suites against the same engine the check
just used.
Note
Pin
libchdbengine to v26.7.3 and bump native npm subpackages to26.7.3-stable.1Updates the engine pin from the v26.7.2-rc.2 pre-release to the stable v26.7.3 release across the build script, npm package config, and documentation.
CHDB_ENGINE_PINtov26.7.3andLIBCHDB_NPM_VERSIONto26.7.3-stable.1in update_libchdb.sh@chdb/lib-*optionalDependencies in package.json to26.7.3-stable.1Macroscope summarized d09c280.