Repository navigation
Stop the client when an event handler raises - #74
Merged
Merged
Conversation
Handler exceptions were handled in three ways: while handling a server message the client disconnected with bad protocol; during a connection attempt or a teardown they were logged and the client carried on; from a state change inside connect(), subscribe() or unsubscribe() the change completed and the call raised. Now every exception escaping a handler fails the same loud way, as in centrifuge-js: it is passed to the event loop's exception handler, and the client disconnects with bad protocol and doesn't reconnect. The SDK's own work completes as if the handler had returned, as for a handler calling disconnect(), and a publication whose handler raised doesn't count as delivered, so a recovery delivers it again. Handlers are called through a guard that looks them up at call time, so a handler replaced on the handler object is still guarded. The README section on callbacks that raise describes the behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while running the SDK fuzz programs.
Stop the client when an event handler raises
Handler exceptions used to be handled in three different ways:
connect(),subscribe()orunsubscribe(), the change completed and the call raised.Now every exception escaping a handler fails the same loud way, as in centrifuge-js:
The SDK's own work completes as if the handler had returned. A publication whose handler raised doesn't count as delivered, so a recovery delivers it again. The README section on callbacks that raise describes the behaviour.