Repository navigation
fix(statistics): mobility backfill keeps unfetched days; visible 0% home stay - #691
Merged
Merged
Conversation
Zeroupper
force-pushed
the
fix/distance-from-location
branch
from
September 16, 2026 11:54
b67ed3b to
222b4b1
Compare
Zeroupper
changed the title
There was a problem hiding this comment.
🔵 Needs a closer look
The mobility card can still render with empty mobility content when only distance data exists.
Pull request overview
Fixes mobility backfill retention, clarifies measured 0% home stay, and removes duplicated distance from the mobility card.
Changes:
- Preserve mobility days omitted from partial backfills.
- Render a faint track for measured 0% home stay.
- Remove duplicate distance display and update dependencies/localizations.
- Update the mobility-card visibility predicate to avoid empty cards when only distance data exists.
File summaries
| File | Summary |
|---|---|
test/data_backfill_test.dart |
Adds backfill retention coverage. |
pubspec.lock |
Updates mobility_features to 6.2.1. |
lib/view_models/cards/mobility_data_model.dart |
Preserves uncovered mobility days. |
lib/ui/cards/mobility_card.dart |
Updates visualization and removes distance display. |
assets/lang/es.json |
Removes obsolete distance translation. |
assets/lang/en.json |
Removes obsolete distance translation. |
assets/lang/da.json |
Removes obsolete distance translation. |
Review details
Suppressed comments (1)
lib/ui/cards/mobility_card.dart:74
- Removing the distance feature leaves
hasDatacountingday.distance > 0(mobility_data_model.dart:14). A day that only has a distance reading will therefore still render this card, but it now shows-, 0 places, and an empty home-stay bar while the distance is shown in the separate card. Please update the mobility-card visibility predicate to require a displayed mobility feature (places or homeStay), while keepinghasDistanceDatafor the distance card.
_feature('${_day.places}', locale.translate('cards.mobility.places')),
- Files reviewed: 6/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobility card fixes only. Distance is computed in
mobility_featuresand was always 0 there - fixed at the source in carp-dk/flutter-plugins#1306; nothing app-side needed once carp_context_package picks up mobility_features 6.2.1.