Skip to content

mutate: Remove algebric rewrites that breaks semantics - #2774

Merged
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
tamaroning:fix-float-identity-peephole-rules
Oct 20, 2026
Merged

alexcrichton merged 1 commit into
bytecodealliance:mainfrom
tamaroning:fix-float-identity-peephole-rules

Conversation

@tamaroning

Copy link
Copy Markdown
Contributor

Fix #2768

@tamaroning
tamaroning requested a review from a team as a code owner October 18, 2026 11:02
@tamaroning
tamaroning requested review from pchickey and removed request for a team October 18, 2026 11:02
@alexcrichton

Copy link
Copy Markdown
Member

Could these perhaps be moved behind the preserve-semantics-disabled check instead of outright deleting them?

@tamaroning
tamaroning force-pushed the fix-float-identity-peephole-rules branch from 325b6fb to 0d16ec4 Compare October 20, 2026 07:42
@tamaroning

Copy link
Copy Markdown
Contributor Author

Could these perhaps be moved behind the preserve-semantics-disabled check instead of outright deleting them?

Yes. Agreed. I've moved them.

@alexcrichton
alexcrichton added this pull request to the merge queue Oct 20, 2026
Merged via the queue into bytecodealliance:main with commit 7f6e307 Oct 20, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mutate breaks semantics: x + 0.0 and x * 1.0 are not identities for floats

2 participants