Skip to content

Add defensive check to pg_stringify_array() to reject non-arrayrefs #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
esabol wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add defensive check to pg_stringify_array() to reject non-arrayrefs #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dbdimp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2933,6 +2933,10 @@ SV * pg_stringify_array(SV *input, const char * array_delim, int server_version,

if (TSTART_slow) TRC(DBILOGFP, "%sBegin pg_stringify_array\n", THEADER_slow);

/* Callers should only pass arrayrefs; defend against misuse */
if (!SvROK(input) || SvTYPE(SvRV(input)) != SVt_PVAV)
croak("Cannot stringify a non-array reference");

toparr = (AV *) SvRV(input);
value = newSVpv("{", 1);
if (utf8)
Expand Down
Loading