Repository navigation
Conversation
Use getPreciseWheelRotation
Contributor
|
Do you have any idea if it is possible that on some hardware |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2865
Problem
On precision touchpads,
MouseWheelEvent.getWheelRotation()is always 0 and the movement is only reported throughgetPreciseWheelRotation(). The direction checks usegetWheelRotation() < 0, which is never true for these events, so every swipe is treated as a down/right scroll.Change
In
MouseWheelListenerBase.javaandScrollViewInteraction.java:getWheelRotation() < 0→getPreciseWheelRotation() < 0getWheelRotation() == 0→getPreciseWheelRotation() == 0.0, for consistency. Touchpad events don't reach this check today, so it isn't needed for the fix and I'm happy to drop it.The scroll amount logic is unchanged. A classic mouse wheel reports whole numbers in both methods, so its behaviour is the same as before.
Testing
Built from master and tested on Windows 11 with an HP ZBook Power G10 precision touchpad:
Also tested on an older laptop with a non-precision touchpad: scrolling worked before the change and still works after it.
Not tested: macOS and Linux touchpads. Feedback from anyone with that hardware is welcome.