Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InjectPTXAsyncCopycurrently strips the base from vector ramps without checking their strides. A 16-bytecp.asyncthen copies contiguous bytes even if the source or destination is a gather/scatter.Require both ramp strides to be provably one before injecting the instruction, including predicated copies and merged dynamic shared memory. Otherwise keep the original tensor store.
Fixes #20910.
Testing
[0, 1, 2, 3]for a source ramp selecting[0, 2, 4, 6]; the standalone change produced the expected result.ruff check,ruff format --check, andclang-formatpassed for the changed files.