Skip to content

Bump beartype upper bound - #41221

Merged
damccorm merged 1 commit into
apache:masterfrom
aebrahim:patch-3
Nov 12, 2026
Merged

damccorm merged 1 commit into
apache:masterfrom
aebrahim:patch-3

Conversation

@aebrahim

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added python size/xs XS: <10 lines changed labels Nov 11, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates the upper bound for the beartype dependency in sdks/python/setup.py from <0.23.0 to <0.24.0, allowing compatibility with beartype 0.23.x releases. The change is minimal, well-scoped, and safe.

🔍 General Feedback

  • No issues found. Existing usage of beartype.door.is_subhint and beartype.roar.BeartypeDoorException remains compatible with beartype 0.23.x.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.
Backup reviewer: claudevdm (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm

Copy link
Copy Markdown
Contributor

Thanks! This LGTM, but I'd like to let CI checks run. I will merge tomorrow if there are no issues.

@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.55%. Comparing base (a01bffe) to head (61a6b2a).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #41221   +/-   ##
=========================================
  Coverage     58.55%   58.55%           
  Complexity     2277     2277           
=========================================
  Files          1132     1132           
  Lines        169739   169739           
  Branches       1485     1485           
=========================================
+ Hits          99388    99394    +6     
+ Misses        67805    67799    -6     
  Partials       2546     2546           
Flag Coverage Δ
python 80.56% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damccorm
damccorm merged commit bc9e036 into apache:master Nov 12, 2026
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants