[bvolpato]

With success-row propagation enabled, the unsharded BigQuery Storage Write API path can catch exceptions from fused downstream transforms as parsing or conversion errors. A bundle can report success even though a downstream consumer failed. With withErrorHandler, an unrelated input row can also be sent to the dead-letter output.

This change moves successful output outside the parsing and conversion handlers so downstream failures fail the bundle. Actual parsing and conversion errors keep their existing handling. With STORAGE_API_AT_LEAST_ONCE, retrying a failed bundle can duplicate rows that BigQuery already accepted.

The SDK harness regression covers mid-bundle and finish-bundle flushes, with and without an error handler. The targeted GCP tests and Spotless passed locally.

Run the GCP module tests with:

./gradlew :sdks:java:io:google-cloud-platform:test

---

• If this contribution is large, please file an Apache Individual Contributor License Agreement.
• Replace these instructions with a description of your change and why you have made it.
• Mention the appropriate issue in your description (for example: addresses #123 or fixes #456).
• Update CHANGES.md with noteworthy changes.

See CONTRIBUTING.md for contribution guidelines.

[bvolpato]

The GCP retry passed on the same commit: 2,229 tests passed, 237 were skipped, and none failed. Both new fused-harness regression cases passed, as did the streaming-insert KMS test that previously received a BigQuery HTTP 500.

All current-head checks are now complete: 18 successful and one neutral.

[github-actions]

Assigning reviewers:

R: @kennknowles for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[kennknowles]

R: @ahmedabu98

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[ahmedabu98]

This is a good fix for the normal case.

Please look into the case when withErrorHandler is set. When the writer flushes mid-bundle, any downstream error (from success-row propagation) will bubble up past this try-catch and into the try-catch in ConvertMessagesDoFn. The bundle succeeds and whatever row ConvertMessagesDoFn was working on upstream incorrectly goes to the DLQ and never reaches BQ.

I think we should do the same fix in ConvertMessagesDoFn and move .output() outside of the try-catch

[ahmedabu98]

waiting on author