Repository navigation
Close HTTP response bodies when loading compressed HTML - #83
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
LoadURLWithClient closes the selected decompressor, which leaves the underlying HTTP response body open. Invalid compression and unsupported encodings also return without closing the body.
Close the response body after every successful client.Do call and close each decompressor separately. Plain responses still close once.
The regression test covers plain, gzip and deflate responses, invalid compression, unsupported encoding and a read failure. Successful cases also verify the parsed document.
Checks passed on Linux:
Both coverage runs report 73.6%. go vet ./... reports an existing testing.T.Fatalf call from a goroutine at query_test.go:210. The unmodified upstream commit reports the same warning.