Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
This PR would make ACE track separate volume for headphones, because it makes no sense that putting helmet on would lower volume of radio on headphones, since these headphones are either bellow helmet or integrated into helmet. Tank crew or pilot helmets are going to have radio integrated into them, so putting them on would protect crew from loud outside sounds, while keeping radio loud and clear, so they can communicate. They had crew helmets with radio in them in WWII. 😀
Music is similar story. This won't change volume of music playing on speakers in 3D environment, only music played by
playMusic, which is same as playing music in music player app on your PC. Using headphones volume for this is more suitable.This PR won't change anything about volume of radio mods, since apparently these use one global volume. It's on them to implement separate headphones volume, if they wish so. It would be right step for more realism and immersion.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.