Repository navigation
Convert parser IndexError to ExpressionError - #142
Open
Rajeshwari2857 wants to merge 3 commits into
Open
Rajeshwari2857 wants to merge 3 commits into
Rajeshwari2857 wants to merge 3 commits into
Conversation
Signed-off-by: Rajeshwariba Vaghela <r.vaghela2857@gmail.com>
Author
|
I've added a regression test for the malformed expression |
Signed-off-by: Rajeshwariba Vaghela <r.vaghela2857@gmail.com>
Signed-off-by: Rajeshwariba Vaghela <r.vaghela2857@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97
Convert parser
IndexErrortoExpressionErrorMy solution will be able to handle
IndexErrorraised when parsing malformed license expressions with empty parentheses.It will also convert the unexpected parser exception into an
ExpressionErrorso thatvalidate()can report the error instead of crashing.