Repository navigation
Fix notification permissions and add onboarding and reset controls - #4
Merged
Merged
Conversation
XDanfr
marked this pull request as ready for review
September 30, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cadence previously scheduled reminders without checking macOS permission and always showed Enable notifications, even after permission changed in System Settings. This reads the actual status, refreshes on activation, requests only undecided permissions, shows denied/registration errors separately, and replaces the permission action with a test reminder when authorised. Async replacements are serialised so pausing/resetting cannot restore an outdated notification.
Adds four-step first-run setup with optional notification access, live appearance previews, setup replay under Settings → Data, confirmed history resets for today / last seven days / inclusive custom dates / all history, and a full reset that stops the timer/alarm, unregisters launch at login, clears Cadence reminders and restores onboarding. Existing data is preserved during setup; full reset prevents reimport from the old bundle identifier. macOS permissions remain managed by the OS.
Includes tests for permission/status/errors and scheduling races, calendar/DST boundaries and reset persistence. Adds optional CADENCE_SIGNING_IDENTITY for builds with a stable installed signing certificate. Documentation covers setup, resets and development-build permission diagnostics.
Validation: GitHub Actions run passed on the final commit: 20 tests, arm64 + x86_64 release builds targeting macOS 15, bundle/signature validation, packaged-app launch and inspected onboarding screenshot. The native notification probe started from notDetermined and remained awaiting a user decision without reporting an error. CI does not answer the permission prompt or prove banner delivery; those still need verification on the affected Mac. The exact reported no-prompt error was not reproduced in CI, so the UI distinguishes an OS registration/request failure from an actual user denial and provides copyable diagnostics.