Skip to content

Fix notification permissions and add onboarding and reset controls - #4

Merged
XDanfr merged 3 commits into
mainfrom
feat/notifications-onboarding
Sep 30, 2026
Merged

XDanfr merged 3 commits into
mainfrom
feat/notifications-onboarding

Conversation

@XDanfr

@XDanfr XDanfr commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

Cadence previously scheduled reminders without checking macOS permission and always showed Enable notifications, even after permission changed in System Settings. This reads the actual status, refreshes on activation, requests only undecided permissions, shows denied/registration errors separately, and replaces the permission action with a test reminder when authorised. Async replacements are serialised so pausing/resetting cannot restore an outdated notification.

Adds four-step first-run setup with optional notification access, live appearance previews, setup replay under Settings → Data, confirmed history resets for today / last seven days / inclusive custom dates / all history, and a full reset that stops the timer/alarm, unregisters launch at login, clears Cadence reminders and restores onboarding. Existing data is preserved during setup; full reset prevents reimport from the old bundle identifier. macOS permissions remain managed by the OS.

Includes tests for permission/status/errors and scheduling races, calendar/DST boundaries and reset persistence. Adds optional CADENCE_SIGNING_IDENTITY for builds with a stable installed signing certificate. Documentation covers setup, resets and development-build permission diagnostics.

Validation: GitHub Actions run passed on the final commit: 20 tests, arm64 + x86_64 release builds targeting macOS 15, bundle/signature validation, packaged-app launch and inspected onboarding screenshot. The native notification probe started from notDetermined and remained awaiting a user decision without reporting an error. CI does not answer the permission prompt or prove banner delivery; those still need verification on the affected Mac. The exact reported no-prompt error was not reproduced in CI, so the UI distinguishes an OS registration/request failure from an actual user denial and provides copyable diagnostics.

@XDanfr
XDanfr marked this pull request as ready for review September 30, 2026 22:51
Copilot AI balanced review requested due to automatic review settings September 30, 2026 22:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@XDanfr
XDanfr merged commit 2c9a927 into main Sep 30, 2026
4 checks passed
@XDanfr
XDanfr deleted the feat/notifications-onboarding branch September 30, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants