Repository navigation
feat(backend): list submissions by hackathon ID - #367
Merged
Merged
Conversation
sabinem
requested changes
Oct 22, 2026
| } | ||
| switch req.GetValue().(type) { | ||
| case *msgs.ListSubmissionsRequest_TeamId: | ||
| teamID := uuid.MustParse(req.GetTeamId()) // Guarded upstream. |
Collaborator
There was a problem hiding this comment.
fix: uuid.MustParse so far it is not used in any service and I would not start to use it here:
- it creates a dependency on the API to provide the check
- in case the check is removed there the backend would crash (effect out of proportion)
teamID, err := uuid.Parse(req.GetTeamId())
if err != nil {
return nil, status.Errorf(codes.InvalidArgument, "invalid team_id: %v", err)
}
Contributor
Author
There was a problem hiding this comment.
Fair point. We used MustParse in Custodian/DAC Portal so I thought having it here with tests would make sense for readability and avoid "dead code", but it's true that we use Parse everywhere else so I'll put it back.
| query = query.Where(entsubmission.HasTeamWith(entteam.IDEQ(teamID))) | ||
|
|
||
| case *msgs.ListSubmissionsRequest_HackathonId: | ||
| hackathonID := uuid.MustParse(req.GetHackathonId()) // Guarded upstream. |
sabinem
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListSubmissionsnow takes either ahackathon_idor ateam_idas parameterCloses #332