Skip to content

pdep: confine network ids to one path component - #219

Merged
alongd merged 1 commit into
mainfrom
i050-network-id-confinement
Oct 2, 2026
Merged

alongd merged 1 commit into
mainfrom
i050-network-id-confinement

Conversation

@alongd

@alongd alongd commented Oct 1, 2026

Copy link
Copy Markdown
Member

Summary

  • reject network_id values that escape, collapse, or nest the round namespace
  • preserve the legacy network_id=None layout
  • add regression coverage for pre-fix path behavior and post-fix refusal

Verification

  • Real-function probe passes the escape/collapse/nesting flips and retained run-tree path comparison.
  • python -m pytest tests/test_pdep -q is not locally executable: both this branch and official/main stop during collection with the same pandas/pyarrow versus NumPy 2.2.6 ImportError (38 collection errors).
  • No cluster submissions or quantum-chemistry runs were performed.

CI should provide the final full-suite result.

@codecov-commenter

codecov-commenter commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.90%. Comparing base (1dae24c) to head (c0e97de).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   81.89%   81.90%   +0.01%     
==========================================
  Files          78       78              
  Lines       12924    12943      +19     
  Branches     2723     2731       +8     
==========================================
+ Hits        10584    10601      +17     
- Misses       1694     1695       +1     
- Partials      646      647       +1     
Flag Coverage Δ
unittests 81.90% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new validation error inaccurately describes nested and collapsing paths as outside the project.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Confines PDep round artifacts to safe, single-component network namespaces while preserving legacy paths.

Changes:

  • Rejects escaping, nested, or collapsing network IDs.
  • Adds regression coverage for valid, invalid, and legacy layouts.
File Description
t3/​pdep/​pes_rounds.py Validates network IDs before resolving round paths.
tests/​test_pdep/​test_pes_rounds.py Tests confinement and legacy behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread t3/pdep/pes_rounds.py Resolved
@alongd
alongd force-pushed the i050-network-id-confinement branch from 68c2887 to bfd2ab4 Compare October 2, 2026 05:57
@alongd
alongd requested a balanced review from Copilot October 2, 2026 07:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Some rejected paths receive factually inaccurate diagnostics.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
Resolved since last review (1)

Comment thread t3/pdep/pes_rounds.py Resolved
@alongd
alongd force-pushed the i050-network-id-confinement branch 3 times, most recently from 68f3b30 to 5af64e8 Compare October 2, 2026 15:13
@alongd
alongd requested a balanced review from Copilot October 2, 2026 16:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

A direct-child symlink alias can still collapse two network IDs into the same round tree.

Review effort: Balanced
Findings: 1 High severity

Open (1)
Resolved since last review (1)

Comment thread t3/pdep/pes_rounds.py Resolved
@alongd
alongd force-pushed the i050-network-id-confinement branch from 5af64e8 to 7d918c4 Compare October 2, 2026 17:30
@alongd
alongd force-pushed the i050-network-id-confinement branch from 7d918c4 to c0e97de Compare October 2, 2026 18:29
@alongd
alongd requested a balanced review from Copilot October 2, 2026 19:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The confinement logic is comprehensive, preserves compatibility, and has targeted regression coverage.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@alongd
alongd merged commit c82e47b into main Oct 2, 2026
5 checks passed
@alongd
alongd deleted the i050-network-id-confinement branch October 2, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants