Repository navigation
pdep: confine network ids to one path component - #219
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 81.89% 81.90% +0.01%
==========================================
Files 78 78
Lines 12924 12943 +19
Branches 2723 2731 +8
==========================================
+ Hits 10584 10601 +17
- Misses 1694 1695 +1
- Partials 646 647 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new validation error inaccurately describes nested and collapsing paths as outside the project.
Review effort: Balanced
Findings: 1
What changed in this PR
Confines PDep round artifacts to safe, single-component network namespaces while preserving legacy paths.
Changes:
- Rejects escaping, nested, or collapsing network IDs.
- Adds regression coverage for valid, invalid, and legacy layouts.
| File | Description |
|---|---|
t3/pdep/pes_rounds.py |
Validates network IDs before resolving round paths. |
tests/test_pdep/test_pes_rounds.py |
Tests confinement and legacy behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alongd
force-pushed
the
i050-network-id-confinement
branch
from
October 2, 2026 05:57
68c2887 to
bfd2ab4
Compare
alongd
force-pushed
the
i050-network-id-confinement
branch
3 times, most recently
from
October 2, 2026 15:13
68f3b30 to
5af64e8
Compare
alongd
force-pushed
the
i050-network-id-confinement
branch
from
October 2, 2026 17:30
5af64e8 to
7d918c4
Compare
alongd
force-pushed
the
i050-network-id-confinement
branch
from
October 2, 2026 18:29
7d918c4 to
c0e97de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Verification
python -m pytest tests/test_pdep -qis not locally executable: both this branch and official/main stop during collection with the same pandas/pyarrow versus NumPy 2.2.6 ImportError (38 collection errors).CI should provide the final full-suite result.