Repository navigation
Remove the all-missing column workaround now fixed in TabPFN - #66
Draft
adrian-prior wants to merge 2 commits into
Draft
adrian-prior wants to merge 2 commits into
adrian-prior wants to merge 2 commits into
Conversation
TabPFN restores the fit-time value of columns that are constant at fit (PriorLabs/TabPFN#1329), so fit_tfm no longer needs to drop them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TabPFN 9.1 handles a column that is entirely missing at fit and holds strings at predict, so fit_tfm no longer needs to drop such columns. Relock to tabpfn 9.2.0, correct the tabpfn license notes, and test that an all-missing column reaches the estimator in training column order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PivQFscAkcPNjCnGHYkCJF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by Claude Code
#54 dropped training columns that are entirely missing, so that a string in such a column at predict could not crash TabPFN (#51). TabPFN handles this itself from 9.1.0 (PriorLabs/TabPFN#1329), so this PR removes the workaround from
fit_tfmand replaces its tests with one that checks an all-missing column reaches the estimator at fit and predict. Therdblearnextra now requirestabpfn>=9.1, anduv.lockmoves from 9.0.0 to 9.2.0.Not covered by this PR:
tabpfn-relalso fits throughfit_tfm. Itslocalextra allowstabpfn9.0.0, which still crashes without the workaround, and itsapiextra was not tested.Verification
CI does not install the
rdblearnextra, so the checks below with real TabPFN ran by hand on CPU.fit_tfmandpredict_tfmwith therdblearnrecipes (TabPFN v2 and v2.5), binary classification and regression. The training column was entirely missing as floatNaN, entirely missing as objectNaN, or populated in the frame but entirely missing in the sampled context rows. The column held strings (including"") at predict.tabpfn==9.1.0andtabpfn==9.2.0: all 12 cases pass. Predictions are identical to a fit without the column (maximum absolute difference 0), with ROC AUC 0.99 and R² 0.97 or higher on synthetic data.tabpfn==9.0.0(control, installed without the extra): all 12 cases fail withValueError: could not convert string to float.tabpfn-rel: pass on 9.1.0 and 9.2.0, fail on 9.0.0.rdblearncode paths that touch the TabPFN API (create_default_for_version, the prediction batch setting, median regression output) run on 9.1.0 and 9.2.0. A fullrdblearnbenchmark run was not repeated.ruff format --check,ruff check,pytest(526 passed, 18 skipped, before the new test;test_tfm.pywith it: 9 passed),uv build --all-packages,workflows/verify_distributions.py.pre-commit run --all-filespasses.Details
fit_tfmmatches its state before Drop all-missing training columns before fitting tabular models #54.predict_tfmpasses columns in training order; it fails when that reindex is removed.docs/licensing.mdno longer sayrdblearnallows 8.x. They now nametabpfn-rel-apias the extra that still allows it, throughtabpfn-extensions>=0.6.3, which requirestabpfn>=8.4.0.uv.lockwas regenerated with uv 0.12.8; the only changes are thetabpfnspecifier and version.tabpfn9.0.0 to 9.2.0. 9.1.0 also ships other fixes that change predictions, so reruns of results recorded on 9.0.0 (baseline_results/README.md) can differ.🤖 Generated with Claude Code
https://claude.ai/code/session_01PivQFscAkcPNjCnGHYkCJF