Repository navigation
feat!: change ResourceReviewRemediated.getAction() return type to ResourceReviewRemediatedAction - #265
Open
fern-api[bot] wants to merge 4 commits into
Open
feat!: change ResourceReviewRemediated.getAction() return type to ResourceReviewRemediatedAction#265fern-api[bot] wants to merge 4 commits into
fern-api[bot] wants to merge 4 commits into
Conversation
Generated by Fern CLI Version: unknown Generators: - fernapi/fern-java-sdk: 4.32.4
… return type to ResourceReviewRemediatedAction Change `ResourceReviewRemediated.getAction()` from returning `Optional<String>` to `Optional<ResourceReviewRemediatedAction>`, introducing a new enum type that encodes the possible review actions (removed_codings, removed_fields, flagged_required). Callers that read or compare the action as a plain string must migrate to the new enum. Also refactor `@JsonAnySetter` handling across all builder types to use a private `putAdditionalPropertyFromJson` method that guards against overwriting known fields, preventing deserialization collisions when unknown JSON keys shadow known property names. Additional documentation updates clarify `DocumentMultiResponse.getPageClassifications()` (now returned on every request, not only when page_filter/split_classifications is set), `ResourceReview.getTargets()` (empty list disables the audit), `ResourceReviewResult.getRemediated()` (covers all review outcomes), and `ProfileUploadRequest.getImplementationGuide()` (phenoml_hpo is now also a reserved IG name). Key changes: - `ResourceReviewRemediated.getAction()` / `Builder.action(...)` — return type changed from `Optional<String>` to `Optional<ResourceReviewRemediatedAction>`; update callers to use enum constants - `putAdditionalPropertyFromJson` private guard method added to all builder types to prevent known-field keys from landing in `additionalProperties` during JSON deserialization - `DocumentMultiResponse.getPageClassifications()` Javadoc updated: field is now populated on every request, not only when a page filter or split classification is supplied - `ResourceReview.getTargets()` Javadoc updated: an empty list now explicitly disables the audit - `ProfileUploadRequest.getImplementationGuide()` Javadoc updated: `phenoml_hpo` added as a reserved IG name alongside `us_core` 🌿 Generated with Fern
|
This PR is too large for Bugbot to review. It changes 47,952 lines and 3,907,542 characters. Split the change into smaller pull requests to get a review. |
…773f517f18a4d3fa [skip ci]
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking: MAJOR because
ResourceReviewRemediated.getAction()changed its return type fromOptional<String>toOptional<ResourceReviewRemediatedAction>, and bothBuilder.action(String)andBuilder.action(Optional<String>)overloads were replaced withResourceReviewRemediatedAction-typed equivalents, breaking all existing callers that pass or compare string values.Breaking Changes
ResourceReviewRemediated.getAction()— now returnsOptional<ResourceReviewRemediatedAction>instead ofOptional<String>; replace string comparisons withResourceReviewRemediatedActionenum constants, and updateBuilder.action(...)call sites to passResourceReviewRemediatedActioninstead ofString.Added
RequestOptions.Builder.addBodyProperty()/.bodyProperties()— inject arbitrary key/value pairs into JSON or form-urlencoded request bodies, acting as the full body for endpoints with no defined body schema.RetryInterceptor.newAsyncCall()— async retry factory that schedules backoff on a daemon thread, freeing OkHttp dispatcher slots and enabling immediate cancellation.Stream.fromSseWithEventDiscrimination()andSseEventParser.parseEventLevelUnion()— new SSE stream factories supporting event-type-discriminated union deserialization from the full SSE envelope.DeviceExposureRow,DeviceExposureContext,DeviceExposureLink,DeviceExposureEvidence,SpecimenRow,AllergyCodingEvidence,AllergyMappingResolution, and related enum types added to thefhir2omoppackage;OmopTablesnow exposesgetDeviceExposure()andgetSpecimen().DrugExposureRow.getQuantity(),MeasurementRow.getUnitSourceConceptId(),VisitOccurrenceRow.getVisitSourceConceptId(),ProviderRow.getNpi(),Summary.getRowsForReview(),MappingEntry.getSourceCodingIndex(), andMappingEntry.getResolution()added.Changed
additionalPropertiesdeserialization — all request and response builder types now filter known JSON field names out ofadditionalProperties, preventing duplicate capture of recognized fields.CreateMultiRequest.getSmallNote()— new optional boolean field that bills at the small-note rate;textmust be ≤ 15,360 bytes UTF-8 whentrue.CreateMultiRequest/DocumentMultiRequestfield documentation —getImplementationGuide()andgetDetectionEffort()docs updated;deepandstandarddetection effort now produce identical results and the field is deprecated.DocumentMultiResponse.getPageClassifications()— now populated on every document request, not only whenpage_filterorsplit_classificationsis explicitly set.MappingPathandMappingPathMappingStatus— new response type and open enum describing a single OMOP concept-mapping chain step, withALREADY_STANDARD,MAPPED, andPOLICY_MAPPEDconstants.Fixed
@JsonAnySetterguard on agent builder types — known field names are no longer accidentally routed intoadditionalPropertiesduring JSON deserialization.See full changelog