Repository navigation
Conversation
Member
|
Closing this as it violates agents.md, with the human not reviewing the change or writing communication themselves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and proposal
Closes #14376.
Expose opt-in native capabilities for plugins supporting classic combat and clients that do not use an off-hand. Existing public events can control damage and gameplay policy, but cannot select native projectile intersection/flight order, all player knockback/movement paths, or off-hand eligibility across native selectors. Post-event corrections can therefore use lost collision state or leave predictive inventory disagreement.
This is an extension proposal, not a claim that modern vanilla combat is defective. Native defaults remain unchanged. The implementation targets maintained
ver/26.2, upstream base58e6e45d67c998909581f9079189ef51eb6f1267; it has not been ported or validated againstmain/26.3.Implementation and boundaries
The branch contains a single generic commit on public upstream ancestry. The feature patch changes are regenerated context/index updates needed by the source patches, not additional optimizations. The broad capability surface is proposed for maintainer review; it can be split or narrowed based on accepted API scope.
Executed validation
On this source tree before its commit (no code changes since):
API XML: 519 executions, no failures/errors, 2 skips. Server XML: 9330 executions, no failures/errors, 22 skips. Suites may execute cases more than once; these are not unique test counts. Native default controls cover the unselected profile, modern weapons and ordinary equipment routes. Regressions cover launch/flight, collision boundaries, Punch, embedded-arrow release, fishing pulls, player impulses and off-hand routing/selectors.
Paperclip SHA-256:
c64fba9a36662d9782a79c19f6f6dade1132756d41eeb97e33b5c6990d1aeffa. No connected-client runtime campaign is attributed to this upstream export.