Repository navigation
BuildableDataComponent Extensions - #13042
Open
Absolutionism wants to merge 11 commits into
Open
Absolutionism wants to merge 11 commits into
Absolutionism wants to merge 11 commits into
Conversation
Toffikk
reviewed
Aug 30, 2025
Doc94
requested changes
Aug 30, 2025
Doc94
left a comment
Doc94
left a comment
Member
There was a problem hiding this comment.
Hi, i think this need a few changes mostly for the unnecesary gradle thing and also names for the set, you can check #12938 for reference.
Also im not sure about all the set methods maybe in a few places can be like Enchantments where a static builder exists for that like
github-project-automation
Bot
moved this from Awaiting review
to Changes required
in Paper PR Queue
Doc94
requested changes
Oct 15, 2025
Owen1212055
approved these changes
Nov 21, 2025
Doc94
force-pushed
the
dev/BuildableDataComponent-Extensions
branch
from
August 3, 2026 02:12
4b034e1 to
165da50
Compare
Doc94
approved these changes
Aug 3, 2026
Member
|
Rebased and include new components in the extension of BuildableDataComponent |
papermc-projects
Bot
moved this from Awaiting review
to Delayed approval
in Paper PR Queue
kennytv
approved these changes
Aug 3, 2026
papermc-projects
Bot
moved this from Delayed approval
to Full approval
in Paper PR Queue
Based in how the component can come this just copy all the values directly.
…sm/dev/BuildableDataComponent-Extensions # Conflicts: # paper-api/src/main/java/io/papermc/paper/datacomponent/item/ItemComponentTypesBridge.java # paper-api/src/main/java/io/papermc/paper/datacomponent/item/KineticWeapon.java # paper-api/src/main/java/io/papermc/paper/datacomponent/item/MapItemColor.java # paper-api/src/main/java/io/papermc/paper/datacomponent/item/PiercingWeapon.java # paper-server/src/main/java/io/papermc/paper/datacomponent/item/ItemComponentTypesBridgesImpl.java # paper-server/src/main/java/io/papermc/paper/datacomponent/item/PaperConsumable.java
Member
|
Ok try a few things for the pending TODO.... (a little help for generate a test... https://pastes.dev/lJDFvwLYzz) |
Contributor
|
what about a itemStack.editData(DataComponentTypes.SOME_BUILDABLE_COMPONENT, builder -> builder.something(...)) |
Member
|
If anyone wanna make another review for this in case still miss something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to update
Componentclasses, that have aBuildersub-class, by extendingBuildableDataComponent, allowing users to retrieve a builder object with the same data from the component object.Additionally, adds setters for some builders, allowing to completely set data rather than just adding. In tandom with
#toBuilderallowing all other data to be kept without the need to recreate and setting each data 1 by 1.#13041