Repository navigation
Send HC4 body unchanged without a Content-Type - #3697
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
`ApacheHttpClient` decoded the request body and passed it to a `StringEntity` together with the content type. Without a `Content-Type` header that type is `null`, and `StringEntity` then encodes the text as ISO-8859-1, so `日本語` was sent as `???`. The body is now sent as the bytes Feign encoded, as the other clients do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApacheHttpClient(HttpClient 4) passes a text body toStringEntitywith the request's content type. When the request has noContent-Typeheader that type isnull, andStringEntityencodes the text as ISO-8859-1, so日本語 àáâis sent as???followed by Latin-1 bytes. The body is now sent as the bytes Feign already encoded, as the other clients do;AbstractClientTest#bodyKeepsRequestCharsetWithoutContentTyperuns for every client and fails forApacheHttpClientTestwithout the change.