Repository navigation
Conversation
What: replace the inert assumeFalse(false, ...) shim in GoogleHttpClientTest.veryLongResponseNullLength with an explicit assumeTrue(Runtime.version().feature() >= 22, ...) skip. Why: with JUnit 5's (condition, message) argument order the old shim never skipped the test. The test hangs on JDK 21 and below (NetHttpTransport blocks reading a response that declares a huge Content-Length but sends only a few bytes) and passes on JDK 22+, as the master CI runs on the JDK 25 test toolchain already show. The new skip runs the test on modern JDKs and skips it cleanly with an accurate message on the JDKs where it hangs. Fixes OpenFeign#2177 Signed-off-by: Inf1mum <vadimlazuk5@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2177
What
Replace the inert
assumeFalse(false, ...)shim inGoogleHttpClientTest.veryLongResponseNullLength()with an explicitassumeTrue(Runtime.version().feature() >= 22, ...)skip.Why
falseas JUnit 5's condition argument (assumeFalse(condition, message)), so it never skipped the test —AbstractClientTest.veryLongResponseNullLength()has been running in CI all along, and master stays green because the test toolchain runs on JDK 25.NetHttpTransportblocks reading a response that declaresContent-Length: Long.MAX_VALUEbut sends only a few bytes.How
GoogleHttpClientTest, the one override added by 2d55093 that was still present (theJAXRSClientTesttwin was already removed).Verification
mvn -pl googlehttpclient -am teston JDK 21.0.5: feign-core 877 tests (4 pre-existing skips) and feign-googlehttpclient 25 tests, all green, withveryLongResponseNullLengthskipped by the new assumption.git-code-format:format-codeproduced no changes (google-java-format clean).Signed-off-by: Inf1mum vadimlazuk5@gmail.com