Repository navigation
implement Theme as dataclass - #377
Closed
Sara-Jade-O wants to merge 1 commit into
Closed
Sara-Jade-O wants to merge 1 commit into
Sara-Jade-O wants to merge 1 commit into
Conversation
ChrisSoderberg-ONS
requested changes
Oct 29, 2026
Collaborator
There was a problem hiding this comment.
@Sara-Jade-O Hi Sara-Jade, the issue this PR addressing was primarly concerned with the amount of attribute setting that was in the class and suggested using a dataclass decorator to simplify it.
Since we have a very similar amount of code in the class before and after using the decorator, I don't think this is addressing the issue at the moment, we've made attribute setting in the init implicit, but it's not improved readability because we still have to list all of the attributes in the class definition anyway.
If we can't slim down the implementation of this class with the dataclass decorator, then I don't think there's any need to use it and we can close this PR and the issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Related Issues
Pre-requisites
This section may not be fully required if the branch is not merging into main.
Please indicate items that aren't necessary and why, with comments around incomplete checks.
been made for it/them