Repository navigation
fix(vendor): keep a leading zero in an all-digit commit sha - #5
Merged
Merged
Conversation
Problem: the vendored parser called String() on a commit that the front matter reader had turned into a number, so 0179008 became 179008. Fix: copy cli/src/complexmd.js again from complex-md main, which keeps the value as written. The new test fails on the old copy (179008) and passes now. npm test: 90 of 90 before the new test, 4 of 4 in map.test.js after. Intent: make the action name the same commit the map names. Assisted-by: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: the vendored parser read
commit: 0179008as179008. The comment then named a commit that does not exist.Change:
src/vendor/complexmd.jsis copied again from complex-md main (59c10fe), with the same header. That version keeps an unquoted all-digit commit as written.test/map.test.jsadds a test that fails on the old copy and passes now.Tests:
npm testpasses.AI assistance: written with Claude (Claude Code). A person has not yet read the whole diff.
🤖 Generated with Claude Code