Skip to content

fix(vendor): keep a leading zero in an all-digit commit sha - #5

Merged
jameslcowan merged 1 commit into
mainfrom
fix/vendor-parser-leading-zero
Oct 25, 2026
Merged

jameslcowan merged 1 commit into
mainfrom
fix/vendor-parser-leading-zero

Conversation

@jameslcowan

Copy link
Copy Markdown
Contributor

Problem: the vendored parser read commit: 0179008 as 179008. The comment then named a commit that does not exist.

Change: src/vendor/complexmd.js is copied again from complex-md main (59c10fe), with the same header. That version keeps an unquoted all-digit commit as written. test/map.test.js adds a test that fails on the old copy and passes now.

Tests: npm test passes.

AI assistance: written with Claude (Claude Code). A person has not yet read the whole diff.

🤖 Generated with Claude Code

Problem: the vendored parser called String() on a commit that the front matter reader had turned into a number, so 0179008 became 179008.

Fix: copy cli/src/complexmd.js again from complex-md main, which keeps the value as written. The new test fails on the old copy (179008) and passes now. npm test: 90 of 90 before the new test, 4 of 4 in map.test.js after.

Intent: make the action name the same commit the map names.
Assisted-by: Claude
@jameslcowan
jameslcowan merged commit 78285f2 into main Oct 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant