Repository navigation
improve edge weight generation - #102
Merged
mschimek merged 3 commits intoAug 21, 2026
Merged
Conversation
mschimek
force-pushed
the
performance/improve-uniform-random-edge-weight-generation
branch
from
August 21, 2026 08:33
8846b71 to
14b4d57
Compare
niklas-uhl
approved these changes
Aug 21, 2026
niklas-uhl
left a comment
niklas-uhl
left a comment
Collaborator
There was a problem hiding this comment.
looks good, apart from the missing code comment
Comment on lines
+46
to
+48
| bool is_canonically_ordered(SInt u, SInt v) { | ||
| return ((u ^ v) & 1u) == 0 ? u < v : u > v; | ||
| } |
Collaborator
There was a problem hiding this comment.
This should definitely have a comment explaining what that does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improve performance of uniform-random edgeweights generation