Repository navigation
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Python sample script, bigquery_federated_view_schema_alloydb.py, and its corresponding unit tests, which demonstrate how to inspect an AlloyDB table schema from BigQuery using federated queries. It also adds the required configuration and dependency files. The feedback points out that noxfile_config.py should be updated to test the oldest supported Python version (3.10) and the newest, while ignoring intermediate versions (3.11 and 3.12) in accordance with testing guidelines.
|
|
||
| TEST_CONFIG_OVERRIDE = { | ||
| # You can opt out from the test for specific Python versions. | ||
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], |
There was a problem hiding this comment.
According to the repository's testing guidelines, only the oldest and newest supported Python releases should be tested in the test configurations, while intermediate versions should be ignored. Since Python 3.10 is the oldest supported version (as specified in requirements-test.txt), it should not be ignored. Instead, intermediate versions like 3.11 and 3.12 should be ignored.
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.10", "3.11"], | |
| "ignored_versions": ["2.7", "3.7", "3.8", "3.9", "3.11", "3.12"], |
References
- Only test the oldest and newest supported Python releases in test configurations (such as noxfile_config.py), ignoring intermediate versions.
06dfbe7 to
7c2ba89
Compare
…inspect AlloyDB table schema via federated query Problem: The BigQuery documentation (https://cloud.google.com/bigquery/docs/alloydb-federated-queries) needs a standalone, tested Python code sample demonstrating how to inspect AlloyDB table schema via federated query (region tag `bigquery_federated_view_schema_alloydb`). Solution: - Add `federated_view_schema_alloydb(project_id: str, connection_id: str) -> None` in `bigquery/federated_queries/bigquery_federated_view_schema_alloydb.py` (Query information_schema.columns in an AlloyDB database from BigQuery using EXTERNAL_QUERY.) - Add unit tests (`bigquery/federated_queries/bigquery_federated_view_schema_alloydb_test.py`) covering both the success path and API error handling (`GoogleAPICallError`)
7c2ba89 to
cba65bc
Compare
…inspect AlloyDB table schema via federated query
Problem:
The BigQuery documentation (https://cloud.google.com/bigquery/docs/alloydb-federated-queries) needs a standalone, tested Python code sample demonstrating how to inspect AlloyDB table schema via federated query (region tag
bigquery_federated_view_schema_alloydb).Solution:
federated_view_schema_alloydb(project_id: str, connection_id: str) -> Noneinbigquery/federated_queries/bigquery_federated_view_schema_alloydb.py(Query information_schema.columns in an AlloyDB database from BigQuery using EXTERNAL_QUERY.)bigquery/federated_queries/bigquery_federated_view_schema_alloydb_test.py) covering both the success path and API error handling (GoogleAPICallError)Description
Fixes #
Checklist
Testing
Compliance & Style
Post-Approval Actions