Repository navigation
Fix: in-app sound effects are way too loud - #2526
Open
feather2222 wants to merge 1 commit into
Open
feather2222 wants to merge 1 commit into
feather2222 wants to merge 1 commit into
Conversation
AudioServicesPlaySystemSound plays at the ringer/alert volume, which makes in-app sound effects much louder than other apps' sounds. Play effects through preloaded AVAudioPlayer instances instead so they follow the media volume, with a modest 0.7 volume to keep them subtle. Fixes Dimillian#2474
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2474
AudioServicesPlaySystemSoundplays sounds at the ringer/alert volume rather than the media volume, so effects like pull-to-refresh and post-sent sound far louder than anything else on the phone.This PR switches
SoundEffectManagerto preloadedAVAudioPlayerinstances so effects follow the media volume, with a fixed 0.7 volume to keep them subtle. Rapid re-triggers rewind the player, matching previous behavior. The public API is unchanged.