Repository navigation
Conversation
PR Dimillian#2508 removed `role: .search` from compact tabs to prevent iOS 18 from forcibly reordering the Explore tab to the end of the bar when placed earlier in custom user tab configurations. However, this also prevented Explore from rendering as the detached floating action button when users deliberately position it at the end. Conditionally assign `role: .search` only when `iosTabs.tabs.last == .explore`, falling back to `role: .none` otherwise. This preserves custom tab ordering when Explore is in slots 1–4 while restoring the detached search button when placed last.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2508 removed
role: .searchfrom compact tabs to prevent iOS 18+ from forcibly reordering the Explore tab to the end of the bar when placed earlier in custom user tab configurations.However, this also prevented Explore from rendering as a detached FAB when users deliberately position it at the end.
Solution: We conditionally assign
role: .searchonly wheniosTabs.tabs.last == .explore, falling back torole: .noneotherwise. This preserves custom tab ordering when Explore is in slots 1–4 while restoring the detached search button when placed last.This is great for me, cuz I really prefer this look.
Behold:
