Repository navigation
Conversation
go-nmsg 0.4.0 fixes zlib bomb and container length overflow issues when reading NMSG input. It also unconditionally pulls in github.com/pebbe/zmq4, so building balboa now requires cgo and libzmq. Install libzmq in CI and the Nix shell and document the new build dependency.
Round-trip the reference data through compressed, small and fragmented containers, and check that oversized containers, oversized compressed buffers and checksum mismatches are rejected. Cases involving compressed fragmented containers are skipped, as go-nmsg currently tries to inflate each fragment separately and cannot decode such input.
Exercise the feeder over a local UDP socket with plain, compressed and fragmented containers, payloads from other vendors and malformed containers it is expected to recover from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the
go-nmsgdependency from 0.2.0 to 0.4.0, which hardens NMSG input against zlib bombs and container length overflows. The new version also pulls in ZeroMQ via cgo, so building balboa now needs libzmq.CI, the Nix shell and the
READMEare updated to match. It also adds tests for NMSG format decoding with different container settings and the first tests for the NMSG UDP socket feeder.