Repository navigation
Serialize null MVC responses using their declared type - #465
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MemoryPackOutputFormatteralways writes the one-byte object-null header whencontext.Objectis null, even when MVC supplies a concrete declared type. Null strings, arrays, lists and dictionaries use a four-byte null collection header in MemoryPack, so a client deserializing the response as the declared type cannot read this output.This affects the documented MVC setup that inserts the MemoryPack formatter first: its
CanWriteResultaccepts the response before the normal no-content formatter handles nulls.Change
When a usable declared type is available, send null values through the same typed serializer path as non-null values. Preserve the existing one-byte null output when the type is absent or only
object.Regression tests exercise the public MVC output formatter context with null string/array/list/dictionary values, compare its output to the public serializer, and round-trip the corrected output. Generated-class null and absent/
objectdeclared types cover compatibility.Validation
f96ba3054f14e528b5f75eba4ff02de0b71fa64a: output isFFinstead ofFF FF FF FF.