Repository navigation
Remove Tier prefix from credential type labels and sort alphabetically - #3
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The missing translation-template refresh will fail the pull request’s CI check.
1 open finding
What changed in this PR
Simplifies the Cacti credentials selector by displaying translated type names without tier prefixes.
Changes:
- Removes
Tier X:from option labels. - Sorts labels naturally and case-insensitively.
- Updates the ordering docblock.
| File | Description |
|---|---|
| includes/arrays.php | Simplifies labels and sorts the credential type options. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bmfmancini
approved these changes
Oct 15, 2026
bmfmancini
approved these changes
Oct 15, 2026
bmfmancini
previously approved these changes
Oct 15, 2026
…edential-type # Conflicts: # locales/po/cacti.pot
|
bmfmancini
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The credential type drop-down previously prefixed each type's display name with
Tier X:(e.g. "Tier 1: SNMP v1/v2c Community"). This removes that prefix so the selector shows just the credential type name, and sorts the options alphabetically by display name.Changes
includes/arrays.php— incredentials_type_options():namedirectly instead of__('Tier %d: %s', ...).natcasesort().Notes
__()in the type definitions, so translation is preserved.Tier %d: %sentry inlocales/po/cacti.potis now unused and will drop out on the next POT regeneration.php -lpasses with no syntax errors.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com